Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for canonical k8s #357

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

Thanhphan1147
Copy link
Contributor

@Thanhphan1147 Thanhphan1147 commented Jun 17, 2024

This PR adds an input use-canonical-k8s to the integration-test workflow to allow deploying juju applications on canonical-k8s.

For now, this parameter must be used in conjuction with provider: k8s so that action-operator bootstraps canonical-k8s as a generic cluster when creating the juju controller.

action-operator will add support for canonical-k8s in the future. Until then, this will be used as a workaround since it's needed to test workflows running on canonical-k8s.

Checklist

  • The contributing guide was applied
  • The PR is tagged with appropriate label (urgent, trivial, complex)

@Thanhphan1147 Thanhphan1147 marked this pull request as ready for review June 18, 2024 15:54
@Thanhphan1147 Thanhphan1147 requested a review from a team as a code owner June 18, 2024 15:54
Copy link
Collaborator

@arturo-seijas arturo-seijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like some tests are filing. Can you double check?

if: ${{ inputs.use-canonical-k8s }} == true
id: canonical-k8s
run: |
sudo snap install k8s --channel=1.30-classic/beta --classic
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can reuse the channel input here currently used for microk8s to be able to customise the snap channel

@cbartz
Copy link
Contributor

cbartz commented Nov 14, 2024

@Thanhphan1147 what is the status here, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants